linux-kernel - Re: [PATCH v8] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHlbtTxO7mR9XfGX@wunner.de>
Date: Thu, 17 Jul 2025 22:23:17 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Matthew W Carlis <mattc@...estorage.com>, xueshuai@...ux.alibaba.com,
	anil.s.keshavamurthy@...el.com, bhelgaas@...gle.com, bp@...en8.de,
	davem@...emloft.net, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org, mark.rutland@....com,
	mathieu.desnoyers@...icios.com, mhiramat@...nel.org,
	naveen@...nel.org, oleg@...hat.com, peterz@...radead.org,
	rostedt@...dmis.org, tianruidong@...ux.alibaba.com,
	tony.luck@...el.com,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v8] PCI: hotplug: Add a generic RAS tracepoint for
 hotplug event

On Thu, Jul 17, 2025 at 02:07:50PM -0500, Bjorn Helgaas wrote:
> and IIUC, it would be helpful for you to add:
> 
>   - DSP Vendor/Device ID (the Root Port or Switch Downstream Port,
>     which is relatively static, so seems less useful to me than the
>     USP/EP would be)

Right, this is already logged in dmesg upon enumeration of the hotplug port,
as well as available via lspci.

>   - USP/EP Vendor/Device ID

There's no 1:1 relation between link or presence events on the one hand,
and enumeration of hotplugged components on the other hand:  The link
may go up but the kernel may fail to enumerate the component, e.g. because
it was yanked before it could be enumerated, or because the kernel has run
out of MMIO space or bus numbers.

Hence this would have to be logged through a separate tracepoint in
pciehp_configure_device(), not by changing the tracepoints added here.

Thanks,

Lukas