linux-kernel - Re: [PATCH] RISC-V: KVM: Use find_vma_intersection() to search for intersecting VMAs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhSdy26sV0SKjzKJoWF9vH2gLsBnqRfV1rCrWGokM0E=w0nJg@mail.gmail.com>
Date: Thu, 17 Jul 2025 12:20:04 +0530
From: Anup Patel <anup@...infault.org>
To: zhouquan@...as.ac.cn
Cc: ajones@...tanamicro.com, atishp@...shpatra.org, paul.walmsley@...ive.com, 
	palmer@...belt.com, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, kvm@...r.kernel.org, 
	kvm-riscv@...ts.infradead.org
Subject: Re: [PATCH] RISC-V: KVM: Use find_vma_intersection() to search for
 intersecting VMAs

On Tue, Jun 17, 2025 at 6:43 PM <zhouquan@...as.ac.cn> wrote:
>
> From: Quan Zhou <zhouquan@...as.ac.cn>
>
> There is already a helper function find_vma_intersection() in KVM
> for searching intersecting VMAs, use it directly.
>
> Signed-off-by: Quan Zhou <zhouquan@...as.ac.cn>

LGTM.

Reviewed-by: Anup Patel <anup@...infault.org>

Queued this patch for Linux-6.17

Thanks,
Anup

> ---
>  arch/riscv/kvm/mmu.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c
> index b63650f9b966..3452a8b77af3 100644
> --- a/arch/riscv/kvm/mmu.c
> +++ b/arch/riscv/kvm/mmu.c
> @@ -487,10 +487,11 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm,
>          *     +--------------------------------------------+
>          */
>         do {
> -               struct vm_area_struct *vma = find_vma(current->mm, hva);
> +               struct vm_area_struct *vma;
>                 hva_t vm_start, vm_end;
>
> -               if (!vma || vma->vm_start >= reg_end)
> +               vma = find_vma_intersection(current->mm, hva, reg_end);
> +               if (!vma)
>                         break;
>
>                 /*
> --
> 2.34.1
>