linux-kernel - Re: [PATCH 0/3] irqchip/gic-v5: Fix some static checker issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aHihEUNIPd3AVL96@lpieralisi>
Date: Thu, 17 Jul 2025 09:06:57 +0200
From: Lorenzo Pieralisi <lpieralisi@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Marc Zyngier <maz@...nel.org>,
	Sascha Bischoff <sascha.bischoff@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Timothy Hayes <timothy.hayes@....com>
Subject: Re: [PATCH 0/3] irqchip/gic-v5: Fix some static checker issues

On Wed, Jul 16, 2025 at 02:37:16PM -0500, Dan Carpenter wrote:
> These are few things that Smatch complained about.  I have not tested
> these patches.  Patch 3 in particular probably needs to be reviewed
> more carefully.

Thanks a lot Dan for reporting (and fixing) them. I had a look
at the patches, [1-2] are obviously correct, patch 3 seems correct
too albeit it could be split in two and I need to test the error
handling loop.

I don't know at this stage what's best wrt applying them (where and
how).

Thanks again,
Lorenzo

> 
> Dan Carpenter (3):
>   irqchip/gic-v5: Delete a stray tab
>   irqchip/gic-v5: Fix forever loop in gicv5_its_create_itt_two_level()
>     error handling
>   irqchip/gic-v5: Fix error handling in gicv5_its_irq_domain_alloc()
> 
>  drivers/irqchip/irq-gic-v5-irs.c |  2 +-
>  drivers/irqchip/irq-gic-v5-its.c | 18 +++++++++++++-----
>  2 files changed, 14 insertions(+), 6 deletions(-)
> 
> -- 
> 2.47.2
>