linux-kernel - Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jz479m96.wl-tiwai@suse.de>
Date: Thu, 17 Jul 2025 11:53:25 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Sharan Kumar Muthu Saravanan <sharweshraajan@...il.com>
Cc: tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

On Thu, 17 Jul 2025 05:02:19 +0200,
Sharan Kumar Muthu Saravanan wrote:
> 
> this patch is to fix my previous Commit e518230 i have fixed mute led
> but for by This patch corrects the coefficient mask value introduced
> in commit e518230, which was intended to enable the mute LED
> functionality. During testing, multiple values were evaluated, and an
> incorrect value was mistakenly included in the final commit. This
> update fixes that error by applying the correct mask value for proper
> mute LED behavior.
> 
> Tested on 6.15.5-arch1-1
> 
> Signed-off-by: M SHARAN KUMAR <sharweshraajan@...il.com>

The patch is still not applicable cleanly.
Please try to fix the mailer setup and resubmit.  At best, test to
send a patch to yourself, and try to apply the patch by yourself,
before resubmitting.

Also, don't forget to add the proper Fixes tag pointing to the
commit.  It must be with 12 chars SHA1 ID followed by the commit
summary.  See Documentation/process/submitting-patches.rst for
details.


thanks,

Takashi

> 
> ---
>  sound/pci/hda/patch_realtek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 060db37eab83..062d439e753d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4753,7 +4753,7 @@ static void
> alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
>   if (action == HDA_FIXUP_ACT_PRE_PROBE) {
>   spec->mute_led_polarity = 0;
>   spec->mute_led_coef.idx = 0x0b;
> - spec->mute_led_coef.mask = 1 << 3;
> + spec->mute_led_coef.mask = 3 << 2;
>   spec->mute_led_coef.on = 1 << 3;
>   spec->mute_led_coef.off = 0;
>   snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
> -- 
> 2.50.1