linux-kernel - Re: [PATCH v2 06/13] PCI: xgene-msi: Drop superfluous fields from xgene

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe0d27b2-cc86-4681-b089-b214afbbd3fc@web.de>
Date: Thu, 17 Jul 2025 13:24:56 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Marc Zyngier <maz@...nel.org>, linux-pci@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>, Rob Herring <robh@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>, Toan Le <toan@...amperecomputing.com>
Subject: Re: [PATCH v2 06/13] PCI: xgene-msi: Drop superfluous fields from
 xgene_msi structure

…
> +++ b/drivers/pci/controller/pci-xgene-msi.c
…
> @@ -214,7 +212,7 @@ static void xgene_irq_domain_free(struct irq_domain *domain,
>  	mutex_lock(&msi->bitmap_lock);
>  
>  	hwirq = hwirq_to_canonical_hwirq(d->hwirq);
> -	bitmap_clear(msi->bitmap, hwirq, msi->num_cpus);
> +	bitmap_clear(msi->bitmap, hwirq, num_possible_cpus());
>  
>  	mutex_unlock(&msi->bitmap_lock);
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&msi->bitmap_lock);”?
https://elixir.bootlin.com/linux/v6.16-rc6/source/include/linux/mutex.h#L225

Regards,
Markus