linux-kernel - Re: [PATCH][next] RDMA/mlx5: remove redundant check on err on return expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175275480530.658097.13704229214903648802.b4-ty@kernel.org>
Date: Thu, 17 Jul 2025 08:20:05 -0400
From: Leon Romanovsky <leon@...nel.org>
To: Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org, 
 Colin Ian King <colin.i.king@...il.com>
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] RDMA/mlx5: remove redundant check on err on
 return expression


On Thu, 17 Jul 2025 12:21:08 +0100, Colin Ian King wrote:
> Currently all paths that set err and then check it for an error
> perform immediate returns, hence err always zero at the end of
> the function _mlx5r_umr_zap_mkey.  The return expression
> err ? err : nblocks has a redundant check on the err since err
> is always zero, so just return nblocks instead.
> 
> 
> [...]

Applied, thanks!

[1/1] RDMA/mlx5: remove redundant check on err on return expression
      https://git.kernel.org/rdma/rdma/c/aee80e6ffc5878

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>