linux-kernel - Re: [PATCH v3 3/3] drivers: hwmon: add EMC2101 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eeca688d-e429-4752-844b-031ce6b8e982@roeck-us.net>
Date: Wed, 16 Jul 2025 18:30:31 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Álvaro Fernández Rojas <noltari@...il.com>,
 jdelvare@...e.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 corbet@....net, linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 3/3] drivers: hwmon: add EMC2101 driver

On 7/16/25 09:05, Guenter Roeck wrote:
> On 7/9/25 09:48, Álvaro Fernández Rojas wrote:
>> The Microchip EMC2101 is a SMBus 2.0 fan controller with temperature
>> monitoring.
>> It supports up to 1 fan, 1 internal temperature sensor, 1 external
>> temperature sensor and an 8 entry look up table to create a
>> programmable temperature response.
>>
>> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> 
> This looks very much like a clone of LM63. Why does it warrant a new driver ?
> 

I had another look at the two chips. EMC2101 is indeed - with a few exceptions -
almost identical to LM63. There are minor differences; for example, EMC2101 does
not (or not officially) support temperature offset registers. That does not
warrant a separate driver.

Please add support for EMC2101 to the lm63 driver. If you like, feel free
to "modernize" the lm63 driver to use the with_info API and/or to use regmap,
but a separate driver for what is essentially the same chip is not acceptable.

Thanks,
Guenter