linux-kernel - Re: [PATCH 2/2] PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gghfznmeu3o6wegyr4seqxervrwsszrqvdbrusetsbvravq4cr@mcbvcwi3zh3p>
Date: Thu, 17 Jul 2025 18:08:46 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: linux-kernel@...r.kernel.org, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Jim Quinlan <jim2101024@...il.com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@...ts.infradead.org>, 
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, "open list:BROADCOM STB PCIE DRIVER" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH 2/2] PCI: brcmstb: Replace open coded value with
 PCIE_T_RRS_READY_MS

On Tue, Jun 24, 2025 at 04:19:23PM GMT, Florian Fainelli wrote:
> The delay that we are waiting on in brcm_pcie_start_link() is
> PCIE_T_RRS_READY_MS, use it.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> ---
>  drivers/pci/controller/pcie-brcmstb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 92887b394eb4..7fa2087e85db 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -1337,7 +1337,7 @@ static int brcm_pcie_start_link(struct brcm_pcie *pcie)
>  	 * Wait for 100ms after PERST# deassertion; see PCIe CEM specification
>  	 * sections 2.2, PCIe r5.0, 6.6.1.
>  	 */

We don't need this comment also since it is part of RRS definition. I'll remove
it while applying.

- Mani

> -	msleep(100);
> +	msleep(PCIE_T_RRS_READY_MS);
>  
>  	/*
>  	 * Give the RC/EP even more time to wake up, before trying to
> -- 
> 2.43.0
> 

-- 
மணிவண்ணன் சதாசிவம்