linux-kernel - Re: [PATCH v5 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250718164412.GD2580412@ZenIV>
Date: Fri, 18 Jul 2025 17:44:12 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Masahiro Yamada <masahiroy@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, Willy Tarreau <w@....eu>,
	Thomas Weißschuh <linux@...ssschuh.net>,
	Brendan Higgins <brendan.higgins@...ux.dev>,
	David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>,
	Shuah Khan <shuah@...nel.org>, Jonathan Corbet <corbet@....net>,
	Nicolas Schier <nicolas.schier@...ux.dev>,
	Kees Cook <kees@...nel.org>, Christian Brauner <brauner@...nel.org>,
	Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@....de>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
	linux-doc@...r.kernel.org, workflows@...r.kernel.org,
	linux-mm@...ck.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v5 06/15] fs,fork,exit: export symbols necessary for
 KUnit UAPI support

On Thu, Jul 17, 2025 at 10:48:08AM +0200, Thomas Weißschuh wrote:
> The KUnit UAPI infrastructure starts userspace processes.
> As it should be able to be built as a module, export the necessary symbols.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

No.  This is just plain wrong.  This is way too low-level; teach kernel/umh.c
to provide what you need, but do *not* add more kernel_execve() callers.
And the situation with ramfs needs cleaning up, but "export put_filesystem()"
is not a solution.