linux-kernel - Re: [PATCH v10 1/4] drm: move drm based debugfs funcs to drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2de96bf3-0c63-4db9-b581-f011bc1446c2@oss.qualcomm.com>
Date: Fri, 18 Jul 2025 10:51:55 -0600
From: Jeff Hugo <jeff.hugo@....qualcomm.com>
To: Sunil Khatri <sunil.khatri@....com>,
        Christian König <christian.koenig@....com>,
        dri-devel@...ts.freedesktop.org
Cc: amd-gfx@...ts.freedesktop.org, simona@...ll.ch, tzimmermann@...e.de,
        tursulin@...ulin.net, phasta@...nel.org, dakr@...nel.org,
        linux-kernel@...r.kernel.org, Oded Gabbay <ogabbay@...nel.org>,
        Jonas Karlman <jonas@...boo.se>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Luca Ceresoli <luca.ceresoli@...tlin.com>
Subject: Re: [PATCH v10 1/4] drm: move drm based debugfs funcs to
 drm_debugfs.c

On 7/4/2025 1:55 AM, Sunil Khatri wrote:
> Requirement is to create per client-id based directories to
> hold key debugging information and for that access to
> root debugfs dentry is need which is not in one place
> and that information cannot be stored in drm_device.
> 
> Move the debugfs functionality from drm_drv.c and drm_accel.c
> to drm_debugfs.c This enables debugfs root node reference
> directly drm_debugfs.c and hence enable to create per client-id
> directory.
> 
> v8: Create drm_accel dentry only if it's config is enabled (Jeff, Hugo)
> v8: Merge drm_drv and drm_accel debugfs patches (Koenig, Christian)
> 
> v10: Since we moved drm_debugfs_root, hence to handle drm bridge
> debugfs add a new function which call drm_bridge_debugfs_params where
> drm_debugfs_root is accessible.
> 
> Suggested-by: Christian König <christian.koenig@....com>
> Signed-off-by: Sunil Khatri <sunil.khatri@....com>

 From the Accel perspective, this seems ok.

Reviewed-by: Jeff Hugo <jeff.hugo@....qualcomm.com>