linux-kernel - RE: [PATCH] misc: rtsx: usb: Ensure mmc child device is active when card is present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMHSBOXK6NScsoq6aP3-K0UGsHjDofQj6xJ=MiU4O7CeU6kHTg@mail.gmail.com>
Date: Fri, 18 Jul 2025 11:19:18 -0700
From: Gwendal Grignou <gwendal@...gle.com>
To: ricky_wu@...ltek.com
Cc: Arnd Bergmann <arnd@...db.de>, gfl3162@...il.com, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Gwendal Grignou <gwendal@...gle.com>, 
	kai.heng.feng@...onical.com, Linux Kernel <linux-kernel@...r.kernel.org>, 
	mingo@...nel.org, stable@...r.kernel.org, 
	Ulf Hansson <ulf.hansson@...aro.org>
Subject: RE: [PATCH] misc: rtsx: usb: Ensure mmc child device is active when
 card is present

> > > -                       if (val & (SD_CD | MS_CD))
> > > +                       if (val & (SD_CD | MS_CD)) {
> > > +                               device_for_each_child(&intf->dev, NULL, rtsx_usb_resume_child);
> > Why not calling rtsx_usb_resume() here?

> Because in this time rtsx_usb is not in runtime_suspend, only need to make sure child is not in suspend
> Actually when the program came here this suspend will be rejected because return -EAGAIN

> > >                                 return -EAGAIN;
> > > +                       }

I meant:

if (val & (SD_CD | MS_CD)) {
  rtsx_usb_resume(intf)
  return -EAGAIN;
}

It looks cleaner, as it indicates the the supsend is rejected and
needs to be undone. The code is in the end indentical to the patch you
are proposing. This is just for look anyway, the patch as-is is
acceptable.