linux-kernel - Re: [v3] net: ti: icssg-prueth: Fix buffer allocation for ICSSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <effb9b2a-73da-4e0f-8672-b9d3f800b8b4@web.de>
Date: Fri, 18 Jul 2025 20:30:35 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Simon Horman <horms@...nel.org>, Himanshu Mittal <h-mittal1@...com>,
 netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, MD Danish Anwar <danishanwar@...com>,
 Meghana Malladi <m-malladi@...com>, Paolo Abeni <pabeni@...hat.com>,
 prajith@...com, Pratheesh Gangadhar <pratheesh@...com>,
 Sriramakrishnan <srk@...com>, Roger Quadros <rogerq@...nel.org>,
 Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [v3] net: ti: icssg-prueth: Fix buffer allocation for ICSSG

>> Can the usage of the conditional operator be extended another bit
>> (also for the function “prueth_emac_buffer_setup” for example)?
> 
> 1. (Subjective) The current code seems fine to me

Under which circumstances would you get into the mood to avoid
duplicate source code further?

> 2. (Objective) Your suggestion features unnecessary parentheses, and
>    incorrect indentation and whitespace

Which code formatting would you find more reasonable then instead?

Regards,
Markus