[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4a882430-877c-40e9-b7bd-21d423340b20@norik.com>
Date: Fri, 18 Jul 2025 07:10:49 +0200
From: Primoz Fiser <primoz.fiser@...ik.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>,
Clark Wang <xiaoning.wang@....com>, Andrew Lunn <andrew+netdev@...n.ch>,
davem@...emloft.net, Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
<mcoquelin.stm32@...il.com>, Alexandre Torgue
<alexandre.torgue@...s.st.com>, imx@...ts.linux.dev, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, upstream@...ts.phytec.de,
Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>
Subject: Re: [PATCH 0/2] Populate of_node for i.MX netdevs
Hi Jakub,
On 17. 07. 25 16:02, Jakub Kicinski wrote:
> On Thu, 17 Jul 2025 11:00:35 +0200 Primoz Fiser wrote:
>> Recently when working on predictable network names for i.MX SoCs, it
>> was discovered that of_node sysfs properties are missing for FEC and
>> EQOS interfaces.
>>
>> Without this, udev is unable to expose the OF_* properties (OF_NAME,
>> OF_FULLNAME, OF_COMPATIBLE, OF_ALIAS, etc.) and thus we cannot identify
>> interface based on those properties.
>>
>> Fix this by populating netdev of_node in respective drivers.
>
> Seems legit, but would be good to CC Open Firmware maintainers.
Added Rob & Saravana to CC.
>
> If we want to make propagating the OF linkage a think I think we should
> add a flavor of SET_NETDEV_DEV() which does that for the caller.
> SET_NETDEV_DEV_OF() ?
OK, so you suggest to add MACRO:
#define SET_NETDEV_DEV_OF(net, np) ((net)->dev.of_node = (np))
I like the idea too.
Way cleaner especially if others will join later.
Shall we do that already for v2 or as a separate series?
BR,
Primoz
--
Primoz Fiser
phone: +386-41-390-545
email: primoz.fiser@...ik.com
--
Norik systems d.o.o.
Your embedded software partner
Slovenia, EU
phone: +386-41-540-545
email: info@...ik.com
Powered by blists - more mailing lists