linux-kernel - Re: [PATCH v4] staging: rtl8192u: Rename ChannelPlan to channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025071803-wrongly-acts-3723@gregkh>
Date: Fri, 18 Jul 2025 08:34:09 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Vivek BalachandharTN <vivek.balachandhar@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v4] staging: rtl8192u: Rename ChannelPlan to channel_plan
 and fix index name

On Fri, Jul 18, 2025 at 01:59:25AM +0000, Vivek BalachandharTN wrote:
> This patch renames the global array ChannelPlan to channel_plan
> to follow Linux kernel coding style. Also renamed the index
> variable from channel_plan to chan_plan_idx to avoid
> shadowing and improve readability.
> 
> v2:
> - Fixed Cc list to include Greg and staging list
> 
> v3:
> - Removed EXTRAVERSION = -vivek from Makefile.
> 
> v4:
> - Tested and verified Makefile EXTRAVERSION removal does not break build
> - Removed EXTRAVERSION = -vivek to keep version clean
> 
> Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@...il.com>
> ---
>  Makefile                               |  2 +-

Why are you modifying Makefile and main.c for the whole kernel when you
are just making a coding style change for a single driver file?

Also, please read the documentation for how to properly document your
version changes, they go below the --- line, right?

thanks,

greg k-h