linux-kernel - Re: [PATCH v4 1/6] mm/huge_memory: move unrelated code out of __split_unmapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afe785c6-a1c5-4a29-b406-8a39f696efbd@redhat.com>
Date: Fri, 18 Jul 2025 09:19:08 +0200
From: David Hildenbrand <david@...hat.com>
To: Zi Yan <ziy@...dia.com>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 linux-mm@...ck.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 Antonio Quartulli <antonio@...delbit.com>, Hugh Dickins <hughd@...gle.com>,
 Kirill Shutemov <k.shutemov@...il.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Nico Pache <npache@...hat.com>,
 Ryan Roberts <ryan.roberts@....com>, Dev Jain <dev.jain@....com>,
 Barry Song <baohua@...nel.org>, Balbir Singh <balbirs@...dia.com>,
 Matthew Brost <matthew.brost@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/6] mm/huge_memory: move unrelated code out of
 __split_unmapped_folio()

On 18.07.25 04:29, Zi Yan wrote:
> remap(), folio_ref_unfreeze(), lru_add_split_folio() are not relevant to
> splitting unmapped folio operations. Move them out to __folio_split() so
> that __split_unmapped_folio() only handles unmapped folio splits. This
> makes __split_unmapped_folio() reusable.
> 
> Remove the swapcache folio split check code before __split_unmapped_folio()
> call, since it is already checked at the beginning of __folio_split() in
> uniform_split_supported() and non_uniform_split_supported().
> 
> Along with the code move, there are some variable renames:
> 
> 1. release is renamed to new_folio,
> 2. origin_folio is now folio, since __folio_split() has folio pointing to
>     the original folio already.
> 
> Signed-off-by: Zi Yan <ziy@...dia.com>
> ---

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb