linux-kernel - Re: [PATCH net-next v4 2/4] net: vxlan: add netlink option to bind vxlan sockets to local addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250718073549.GH27043@horms.kernel.org>
Date: Fri, 18 Jul 2025 08:35:49 +0100
From: Simon Horman <horms@...nel.org>
To: Richard Gobert <richardbgobert@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, dsahern@...nel.org, razor@...ckwall.org,
	idosch@...dia.com, petrm@...dia.com, menglong8.dong@...il.com,
	daniel@...earbox.net, martin.lau@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 2/4] net: vxlan: add netlink option to bind
 vxlan sockets to local addresses

On Thu, Jul 17, 2025 at 01:54:10PM +0200, Richard Gobert wrote:

...

> @@ -4596,7 +4615,9 @@ static int vxlan_fill_info(struct sk_buff *skb, const struct net_device *dev)
>  	    nla_put_u8(skb, IFLA_VXLAN_REMCSUM_RX,
>  		       !!(vxlan->cfg.flags & VXLAN_F_REMCSUM_RX)) ||
>  	    nla_put_u8(skb, IFLA_VXLAN_LOCALBYPASS,
> -		       !!(vxlan->cfg.flags & VXLAN_F_LOCALBYPASS)))
> +		       !!(vxlan->cfg.flags & VXLAN_F_LOCALBYPASS)) ||
> +		nla_put_u8(skb, IFLA_VXLAN_LOCALBIND,
> +			   !!(vxlan->cfg.flags & VXLAN_F_LOCALBIND)))

nit: the indentation of the above two lines seems inconsistent with those
     above them - I think it should be a tab and four spaces, rather than
     two tabs.

>  		goto nla_put_failure;
>  
>  	if (nla_put(skb, IFLA_VXLAN_PORT_RANGE, sizeof(ports), &ports))

...