linux-kernel - Re: [PATCH] Revert "scsi: iscsi: Fix HW conn removal use after free"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c4be23d1-7d8c-4944-b530-b8f92ac1adf0@huawei.com>
Date: Fri, 18 Jul 2025 09:07:29 +0800
From: Li Lingfeng <lilingfeng3@...wei.com>
To: Mike Christie <michael.christie@...cle.com>, <lduncan@...e.com>,
	<cleech@...hat.com>, <njavali@...vell.com>, <mrangankar@...vell.com>,
	<GR-QLogic-Storage-Upstream@...vell.com>, <martin.petersen@...cle.com>,
	<jejb@...ux.ibm.com>, <James.Bottomley@...senPartnership.com>
CC: <open-iscsi@...glegroups.com>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <yukuai1@...weicloud.com>,
	<houtao1@...wei.com>, <yi.zhang@...wei.com>, <yangerkun@...wei.com>,
	<chengzhihao1@...wei.com>, <lilingfeng@...weicloud.com>
Subject: Re: [PATCH] Revert "scsi: iscsi: Fix HW conn removal use after free"

Hi, Mike

在 2025/7/18 4:01, Mike Christie 写道:
> On 7/15/25 2:39 AM, Li Lingfeng wrote:
>> This reverts commit c577ab7ba5f3bf9062db8a58b6e89d4fe370447e.
>>
>> The invocation of iscsi_put_conn() in iscsi_iter_destory_conn_fn() is used
>> to free the initial reference counter of iscsi_cls_conn.
>> For non-qla4xxx cases, the ->destroy_conn() callback (e.g.,
>> iscsi_conn_teardown) will call iscsi_remove_conn() and iscsi_put_conn() to
>> remove the connection from the children list of session and free the
>> connection at last.
>> However for qla4xxx, it is not the case. The ->destroy_conn() callback
>> of qla4xxx will keep the connection in the session conn_list and doesn't
>> use iscsi_put_conn() to free the initial reference counter. Therefore,
>> it seems necessary to keep the iscsi_put_conn() in the
>> iscsi_iter_destroy_conn_fn(), otherwise, there will be memory leak
>> problem.
>>
> I must have thought we did a unregister instead of remove for
> some reason. Thanks for catching this.
Just wanted to check – do you still have the original diagnostic
information/data from the UAF issue? Since we're reverting the patch,
perhaps we should revisit the root cause to determine the most
appropriate fix approach.

Thanks,

Lingfeng

>
> Reviewed-by: Mike Christie <michael.christie@...cle.com>
>