linux-kernel - Re: [PATCH v5 1/1] staging: rtl8192u: Rename ChannelPlan to channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025071809-sulfur-unvaried-8e9a@gregkh>
Date: Fri, 18 Jul 2025 09:43:28 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Vivek BalachandharTN <vivek.balachandhar@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/1] staging: rtl8192u: Rename ChannelPlan to
 channel_plan and fix index name

On Fri, Jul 18, 2025 at 02:52:06AM +0000, Vivek BalachandharTN wrote:
> This patch renames the global array ChannelPlan to channel_plan
> to follow Linux kernel coding style. Also renamed the index
> variable from channel_plan to chan_plan_idx to avoid
> shadowing and improve readability.
> 
> v2:
> - Fixed Cc list to include Greg and staging list
> 
> v3:
> - Removed EXTRAVERSION = -vivek from Makefile.
> 
> v4:
> - Tested and verified Makefile EXTRAVERSION removal does not break build
> - Removed EXTRAVERSION = -vivek to keep version clean
> 
> v5:
> - Renamed chan_plan_idx to chan per Dan Carpenter's feedback.
> - Removed mistaken blank line addition in init/main.c.
> - Removed unrelated changes to Makefile and init/main.c.
> 
> Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@...il.com>
> ---
>  drivers/staging/rtl8192u/r8192U_core.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)

Again, please read the documentation file for how to properly put a
version log for the patch (it goes below the --- line.)  Look at the
hundreds/thousands of examples on the public mailing lists for examples
of what to do here.

And also, please make sure that your patch actually applies against the
latest development tree (i.e. linux-next or the subsystem development
tree.)  I don't think that's the case here at all :(

thanks,

greg k-h