Message-ID: <50cdc52b-b0e6-4448-a35d-b033671bb623@kernel.org>
Date: Fri, 18 Jul 2025 09:50:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: "robh@...nel.org" <robh@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "richardcochran@...il.com" <richardcochran@...il.com>,
 Claudiu Manoil <claudiu.manoil@....com>,
 Vladimir Oltean <vladimir.oltean@....com>, Clark Wang
 <xiaoning.wang@....com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "vadim.fedorenko@...ux.dev"
 <vadim.fedorenko@...ux.dev>, Frank Li <frank.li@....com>,
 "shawnguo@...nel.org" <shawnguo@...nel.org>,
 "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
 "festevam@...il.com" <festevam@...il.com>, "F.S. Peng" <fushi.peng@....com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH v2 net-next 02/14] dt-bindings: net: add nxp,netc-timer
 property

On 18/07/2025 09:46, Krzysztof Kozlowski wrote:
> On Thu, Jul 17, 2025 at 10:26:28AM +0000, Wei Fang wrote:
>>>> timestamper:	provides control node reference and
>>>> 			the port channel within the IP core
>>>>
>>>> The "timestamper" property lives in a phy node and links a time
>>>> stamping channel from the controller device to that phy's MII bus.
>>>>
>>>> But for NETC, we only need the node parameter, and this property is
>>>> added to the MAC node.
>>>
>>> I think we do not understand each other. I ask if this is the
>>> timestamper and you explain about arguments of the phandle. The
>>> arguments are not relevant.
>>>
>>> What is this purpose/role/function of the timer device?
>>
>> The timer device provides PHC with nanosecond resolution, so the
>> ptp_netc driver provides interfaces to adjust the PHC, and this PHC
>> is used by the ENETC device, so that the ENECT can capture the
>> timestamp of the packets.
>>
>>>
>>> What is the purpose of this new property in the binding here?
>>>
>>
>> This property is to allow the ENETC to find the timer device that is
>> physically bound to it. so that ENETC can perform PTP synchronization
>> with other network devices.
> 
> 
> Looks exactly how existing timestamper property is described.
> 
> If this is not timestamper then probably someone with better domain
> knowledge should explain it clearly, so I will understand why it is not
> timestamper and what is the timestamper property. Then you should think
> if you need new generic binding for it, IOW, whether this is typical
> problem you solve here or not, and add such binding if needed.
> 
> Maybe there is another property describing a time provider in the
> kernel or dtschema. Please look for it. This all looks like you are
> implementing typical use case in non-typical, but vendor-like, way.


BTW, I am also very disappointed that we had exactly that talk in v1,
for 10 or 20 emails (!!!) and then you send the same.

I feel like you do not want to actually solve this problem, but just
push whatever you have. Otherwise why unresolved comments in v1 would
result in the same code in v2 leading to the same lengthy discussion?

If you send the same v3, I will just NAK it without even discussing,
because 20 emails in v1 and 20 emails in v2 is way too much wasting my time.

Best regards,
Krzysztof

Powered by blists - more mailing lists