linux-kernel - Re: [PATCH v3 07/10] dt-bindings: clock: qcom: Add NSS clock controller for IPQ5424 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49d5d360-6a2f-4dd4-bbd7-1a902e556f00@quicinc.com>
Date: Fri, 18 Jul 2025 17:05:49 +0800
From: Luo Jie <quic_luoj@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Rob Herring
	<robh@...nel.org>
CC: Georgi Djakov <djakov@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>,
        Anusha Rao <quic_anusha@...cinc.com>,
        Konrad Dybcio
	<konradybcio@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Richard
 Cochran" <richardcochran@...il.com>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <quic_kkumarcs@...cinc.com>, <quic_linchen@...cinc.com>,
        <quic_leiwei@...cinc.com>, <quic_pavir@...cinc.com>,
        <quic_suruchia@...cinc.com>
Subject: Re: [PATCH v3 07/10] dt-bindings: clock: qcom: Add NSS clock
 controller for IPQ5424 SoC



On 7/11/2025 8:16 PM, Konrad Dybcio wrote:
> On 7/11/25 12:55 AM, Rob Herring wrote:
>> On Thu, Jul 10, 2025 at 08:28:15PM +0800, Luo Jie wrote:
>>> NSS clock controller provides the clocks and resets to the networking
>>> blocks such as PPE (Packet Process Engine) and UNIPHY (PCS) on IPQ5424
>>> devices.
>>>
>>> Add the compatible "qcom,ipq5424-nsscc" support based on the current
>>> IPQ9574 NSS clock controller DT binding file. ICC clocks are always
>>> provided by the NSS clock controller of IPQ9574 and IPQ5424, so add
>>> interconnect-cells as required DT property.
>>>
>>> Also add master/slave ids for IPQ5424 networking interfaces, which is
>>> used by nss-ipq5424 driver for providing interconnect services using
>>> icc-clk framework.
>>>
>>> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>
>>> ---
> 
> [...]
> 
>>>     clocks:
>>>       items:
>>> @@ -57,6 +61,7 @@ required:
>>>     - compatible
>>>     - clocks
>>>     - clock-names
>>> +  - '#interconnect-cells'
>>
>> You just made this required for everyone. Again, that's an ABI change.
> 
> In this case it's actually valid, but should be a separate fixup change
> 
> Konrad

Making #interconnect-cells a required property does introduce an ABI
change in the device tree bindings. However, this change is necessary
to ensure proper functionality and integration with the interconnect
framework, which increasingly relies on this property for accurate
configuration and resource management.

Yes, this is a fixup change. Since the current NSS clock controller DTS 
node for IPQ9574 already includes '#interconnect-cells', I will separate 
this modification into a standalone fixup patch.