linux-kernel - Re: [PATCH] iio: adc: ad7768-1: disable IRQ autoenable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5llfgo2wifyi43zj24rv7ph5gebevcszrxl3hp3yc3ibaglcr3@fqdejauv6rmo>
Date: Fri, 18 Jul 2025 10:18:56 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Jonathan Santos <Jonathan.Santos@...log.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org, 
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org, jonath4nns@...il.com
Subject: Re: [PATCH] iio: adc: ad7768-1: disable IRQ autoenable

On Thu, Jul 17, 2025 at 10:33:07PM -0300, Jonathan Santos wrote:
> The device continuously converts data while powered up, generating
> interrupts in the background. Configure the IRQ to be enabled and
> disabled manually as needed to avoid unnecessary CPU load.
> 
> Signed-off-by: Jonathan Santos <Jonathan.Santos@...log.com>
> ---

LGTM,

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

>  drivers/iio/adc/ad7768-1.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> index a2e061f0cb08..3eea03c004c3 100644
> --- a/drivers/iio/adc/ad7768-1.c
> +++ b/drivers/iio/adc/ad7768-1.c
> @@ -395,8 +395,10 @@ static int ad7768_scan_direct(struct iio_dev *indio_dev)
>  	if (ret < 0)
>  		return ret;
>  
> +	enable_irq(st->spi->irq);
>  	ret = wait_for_completion_timeout(&st->completion,
>  					  msecs_to_jiffies(1000));
> +	disable_irq(st->spi->irq);
>  	if (!ret)
>  		return -ETIMEDOUT;
>  
> @@ -1130,7 +1132,21 @@ static const struct iio_buffer_setup_ops ad7768_buffer_ops = {
>  	.predisable = &ad7768_buffer_predisable,
>  };
>  
> +static int ad7768_set_trigger_state(struct iio_trigger *trig, bool enable)
> +{
> +	struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
> +	struct ad7768_state *st = iio_priv(indio_dev);
> +
> +	if (enable)
> +		enable_irq(st->spi->irq);
> +	else
> +		disable_irq(st->spi->irq);
> +
> +	return 0;
> +}
> +
>  static const struct iio_trigger_ops ad7768_trigger_ops = {
> +	.set_trigger_state = ad7768_set_trigger_state,
>  	.validate_device = iio_trigger_validate_own_device,
>  };
>  
> @@ -1417,7 +1433,7 @@ static int ad7768_probe(struct spi_device *spi)
>  
>  	ret = devm_request_irq(&spi->dev, spi->irq,
>  			       &ad7768_interrupt,
> -			       IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> +			       IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN,
>  			       indio_dev->name, indio_dev);
>  	if (ret)
>  		return ret;
> 
> base-commit: 0a686b9c4f847dc21346df8e56d5b119918fefef
> -- 
> 2.34.1
>