linux-kernel - Re: [PATCH] arc:kernel:perf_event.c : replaced sprintf with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG+54DZQC+-6E-P3D4BUtVujNegL1qKpcB5SGh28+rX5hrHFiw@mail.gmail.com>
Date: Fri, 18 Jul 2025 15:57:20 +0530
From: Rujra Bhatt <braker.noob.kernel@...il.com>
To: peterz@...radead.org, mingo@...hat.com, acme@...nel.org, 
	namhyung@...nel.org, mark.rutland@....com, alexander.shishkin@...ux.intel.com, 
	jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com, 
	kan.liang@...ux.intel.com, vgupta@...nel.org
Cc: linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-snps-arc@...ts.infradead.org, skhan@...uxfoundation.org, 
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] arc:kernel:perf_event.c : replaced sprintf with sysfs_emit()

Hi,

On Sat, Jul 5, 2025 at 1:00 PM Rujra Bhatt <braker.noob.kernel@...il.com> wrote:
>
> Replaced sprintf() with sysfs_emit() in sysfs*_show() function in
> perf_event.c file to follow the kernel's guidelines from
> documentation/filesystems/sysfs.rst
> This will improve consistency, safety, and makes it easier to maintain
> and update in future.
>
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@...il.com>
> ---
>  arch/arc/kernel/perf_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c
> index ed6d4f0cd621..424ec072c441 100644
> --- a/arch/arc/kernel/perf_event.c
> +++ b/arch/arc/kernel/perf_event.c
> @@ -648,7 +648,7 @@ static ssize_t arc_pmu_events_sysfs_show(struct device *dev,
>         struct perf_pmu_events_attr *pmu_attr;
>
>         pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr);
> -       return sprintf(page, "event=0x%04llx\n", pmu_attr->id);
> +       return sysfs_emit(page, "event=0x%04llx\n", pmu_attr->id);
>  }
>
>  /*
> --
> 2.43.0
>

Gentle reminder for the replacement of sprintf() with the sysfs_emit(), kindly
review it.

Thanking you,
regards,
Rujra Bhatt