linux-kernel - RE: [PATCH] net: mctp: Add MCTP PCIe VDM transport driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEZPR06MB576396B0430AE23A03450ED39050A@SEZPR06MB5763.apcprd06.prod.outlook.com>
Date: Fri, 18 Jul 2025 11:05:22 +0000
From: YH Chung <yh_chung@...eedtech.com>
To: Jeremy Kerr <jk@...econstruct.com.au>, Khang D Nguyen
	<khangng@...eremail.onmicrosoft.com>, "matt@...econstruct.com.au"
	<matt@...econstruct.com.au>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, BMC-SW <BMC-SW@...eedtech.com>
CC: Hieu Le <lhieu@...amperecomputing.com>
Subject: RE: [PATCH] net: mctp: Add MCTP PCIe VDM transport driver

Hi Jeremy,

>Just put them in the top-level at drivers/net/mctp/ for now. There's not much in
>there at present, so will be simple to keep organised. If you end up with two
>drivers and a common set of utils between the two, that's a total of four files,
>which I think we can manage.

Understood, thanks for the guidance!
We plan to start with the AST2700 driver in the next submission, along with the shared utility code.

>YH: so we would just have the three-byte format for your proposed
>driver:
>
>   [0]: routing type (bits 0:2, others reserved)
>   [1]: bus
>   [2]: device / function
>
>- assuming you're only handling non-flit mode for now.
>
Sounds good-We'll apply this format in the next patch.


Hi Adam,

> Would the mailbox abstraction work for this?  It is what I am using in the MCTP over PCC code.  Perhaps a PCIe VDM mailbox implementation will have a wider use  than just MCTP.
>
Thanks a lot for the suggestion! For now, we're planning to remove the current abstraction and use a set of common utility functions shared between the AST2600 and AST2700 drivers.
As Jeremy mentioned, we'd prefer to hold off on introducing a PCIe VDM abstraction layer until there are more concrete use cases that would benefit from it.

>My suggestiong  is: Keep it simple.  There are only a handful of mctp device
>drivers thus far, and there seems to be little justification for a deeper hierarchy.
>
>Just focus on the cleanest implementation.  Having two drivers plus a single
>common source code for each in drivers/net/mctp seems to be easier to
>manage for now.

Appreciate the guidance!
We'll proceed as you and Jeremy suggested and keep everything under drivers/net/mctp for now.