linux-kernel - Re: [PATCH v2] drm/tidss: oldi: convert to devm_drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13a7078f-4ca6-4ec5-9f84-eaad94c64cc4@ideasonboard.com>
Date: Fri, 18 Jul 2025 14:14:55 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Jayesh Choudhary <j-choudhary@...com>
Cc: airlied@...il.com, simona@...ll.ch, linux-kernel@...r.kernel.org,
 jyri.sarha@....fi, maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 tzimmermann@...e.de, dri-devel@...ts.freedesktop.org, devarsht@...com,
 mwalle@...nel.org, aradhya.bhatia@...ux.dev
Subject: Re: [PATCH v2] drm/tidss: oldi: convert to devm_drm_bridge_alloc()
 API

Hi,

On 14/07/2025 13:45, Jayesh Choudhary wrote:
> DRM bridges now use "devm_drm_bridge_alloc()" for allocation and
> initialization. "devm_kzalloc()" is not allowed anymore and it results
> in WARNING. So convert it.
> 
> Fixes: 7246e0929945 ("drm/tidss: Add OLDI bridge support")
> Reviewed-by: Devarsh Thakkar <devarsht@...com>
> Reviewed-by: Aradhya Bhatia <aradhya.bhatia@...ux.dev>
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> ---
> 
> Changelog v1->v2:
> - Fix typo in commit message
> - Put the oldi parent and child node in case of error before returning
>   (as pointed out by Aradhya in v1)
> - Pick up "R-by" tags
> 
> v1 patch link:
> <https://lore.kernel.org/all/20250701055002.52336-1-j-choudhary@ti.com/>
> 
>  drivers/gpu/drm/tidss/tidss_oldi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_oldi.c b/drivers/gpu/drm/tidss/tidss_oldi.c
> index 8223b8fec8ce..8f25159d0666 100644
> --- a/drivers/gpu/drm/tidss/tidss_oldi.c
> +++ b/drivers/gpu/drm/tidss/tidss_oldi.c
> @@ -534,9 +534,10 @@ int tidss_oldi_init(struct tidss_device *tidss)
>  			continue;
>  		}
>  
> -		oldi = devm_kzalloc(tidss->dev, sizeof(*oldi), GFP_KERNEL);
> -		if (!oldi) {
> -			ret = -ENOMEM;
> +		oldi = devm_drm_bridge_alloc(tidss->dev, struct tidss_oldi, bridge,
> +					     &tidss_oldi_bridge_funcs);
> +		if (IS_ERR(oldi)) {
> +			ret = PTR_ERR(oldi);
>  			goto err_put_node;
>  		}
>  
> @@ -577,7 +578,6 @@ int tidss_oldi_init(struct tidss_device *tidss)
>  		/* Register the bridge. */
>  		oldi->bridge.of_node = child;
>  		oldi->bridge.driver_private = oldi;
> -		oldi->bridge.funcs = &tidss_oldi_bridge_funcs;
>  		oldi->bridge.timings = &default_tidss_oldi_timings;
>  
>  		tidss->oldis[tidss->num_oldis++] = oldi;

Thanks, I'll pick this up.

 Tomi