linux-kernel - Re: [PATCH 1/2] cgroup-v1: Fix missing mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccda6da0-5157-4520-a22d-437467ada3e1@web.de>
Date: Fri, 18 Jul 2025 14:23:30 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Zijiang Huang <kerayhuang@...cent.com>, cgroups@...r.kernel.org
Cc: Zijiang Huang <huangzjsmile@...il.com>,
 LKML <linux-kernel@...r.kernel.org>, Hao Peng <flyingpeng@...cent.com>,
 Johannes Weiner <hannes@...xchg.org>, Michal Koutný
 <mkoutny@...e.com>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 1/2] cgroup-v1: Fix missing mutex_unlock in error paths

> In the function, after acquiring the mutex with mutex_lock, multiple return
> paths (such as returning ERR_PTR, NULL, or normal pointers)fail to call
> mutex_unlock to release the lock, which could lead to deadlock risks.

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n94


Will a cover letter become helpful for such a patch series?

Regards,
Markus