linux-kernel - Re: [PATCH v3] ALSA: usb: qcom: Adjust mutex unlock order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pldx7kie.wl-tiwai@suse.de>
Date: Fri, 18 Jul 2025 14:26:17 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Erick Karanja <karanja99erick@...il.com>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ALSA: usb: qcom: Adjust mutex unlock order

On Fri, 18 Jul 2025 09:03:08 +0200,
Erick Karanja wrote:
> 
> The mutexes qdev_mutex and chip->mutex are acquired in that order
> throughout the driver. To preserve proper lock hierarchy and avoid
> potential deadlocks, they must be released in the reverse
> order of acquisition.
> 
> This change reorders the unlock sequence to first release chip->mutex
> followed by qdev_mutex, ensuring consistency with the locking pattern.
> 
> Fixes: e2710ea98124 ("staging: sound: Adjust mutex unlock order")

This commit ID doesn't exist, and the commit summary doesn't sound
right.  You need to put the commit to be fixed with the commit summary
of that commit instead of your own.

Please resubmit with the proper Fixes tag.


thanks,

Takashi