linux-kernel - Re: [PATCH next] coresight: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ9a7VjykdwBd3_Mh88U_Mqpqsi6aNFeeMS_wMsLE7EV4n_iMA@mail.gmail.com>
Date: Fri, 18 Jul 2025 13:47:31 +0100
From: Mike Leach <mike.leach@...aro.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Yuanfang Zhang <quic_yuanfang@...cinc.com>, Suzuki K Poulose <suzuki.poulose@....com>, 
	James Clark <james.clark@...aro.org>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Leo Yan <leo.yan@....com>, 
	coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] coresight: Fix a NULL vs IS_ERR() bug in probe

On Wed, 16 Jul 2025 at 20:38, Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The devm_ioremap_resource() function returns error pointers on error.
> It never returns NULL.  Update the error checking to match.
>
> Fixes: 26e20622a8ae ("coresight: add coresight Trace Network On Chip driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/hwtracing/coresight/coresight-tnoc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tnoc.c b/drivers/hwtracing/coresight/coresight-tnoc.c
> index 0e4164707eea..d542df46ea39 100644
> --- a/drivers/hwtracing/coresight/coresight-tnoc.c
> +++ b/drivers/hwtracing/coresight/coresight-tnoc.c
> @@ -183,8 +183,8 @@ static int trace_noc_probe(struct amba_device *adev, const struct amba_id *id)
>         dev_set_drvdata(dev, drvdata);
>
>         drvdata->base = devm_ioremap_resource(dev, &adev->res);
> -       if (!drvdata->base)
> -               return -ENOMEM;
> +       if (IS_ERR(drvdata->base))
> +               return PTR_ERR(drvdata->base);
>
>         spin_lock_init(&drvdata->spinlock);
>
> --
> 2.47.2
>
Reviewed-by: Mike Leach <mike.leach@...aro.org>

-- 
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK