linux-kernel - Re: [PATCH v3 05/13] arm: Handle KCOV _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250718125853.75g4nv2dnbkklud6@leggings>
Date: Fri, 18 Jul 2025 07:58:53 -0500
From: Nishanth Menon <nm@...com>
To: Kees Cook <kees@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>, Russell King <linux@...linux.org.uk>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner
	<tglx@...utronix.de>,
        Santosh Shilimkar <ssantosh@...nel.org>, Lee Jones
	<lee@...nel.org>,
        Allison Randal <allison@...utok.net>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Ingo
 Molnar <mingo@...nel.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Christoph Hellwig <hch@....de>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nathan Chancellor
	<nathan@...nel.org>,
        Nicolas Schier <nicolas.schier@...ux.dev>,
        Nick
 Desaulniers <nick.desaulniers+lkml@...il.com>,
        Bill Wendling
	<morbo@...gle.com>,
        Justin Stitt <justinstitt@...gle.com>, <linux-kernel@...r.kernel.org>,
        <x86@...nel.org>, <kasan-dev@...glegroups.com>,
        <linux-doc@...r.kernel.org>, <kvmarm@...ts.linux.dev>,
        <linux-riscv@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
        <linux-efi@...r.kernel.org>, <linux-hardening@...r.kernel.org>,
        <linux-kbuild@...r.kernel.org>,
        <linux-security-module@...r.kernel.org>,
        <linux-kselftest@...r.kernel.org>, <sparclinux@...r.kernel.org>,
        <llvm@...ts.linux.dev>
Subject: Re: [PATCH v3 05/13] arm: Handle KCOV __init vs inline mismatches

On 16:25-20250717, Kees Cook wrote:
> When KCOV is enabled all functions get instrumented, unless
> the __no_sanitize_coverage attribute is used. To prepare for
> __no_sanitize_coverage being applied to __init functions, we have to
> handle differences in how GCC's inline optimizations get resolved. For
> arm this exposed several places where __init annotations were missing
> but ended up being "accidentally correct". Fix these cases and force
> several functions to be inline with __always_inline.
> 

[..]

> diff --git a/drivers/soc/ti/pm33xx.c b/drivers/soc/ti/pm33xx.c
> index dfdff186c805..dc52a2197d24 100644
> --- a/drivers/soc/ti/pm33xx.c
> +++ b/drivers/soc/ti/pm33xx.c
> @@ -145,7 +145,7 @@ static int am33xx_do_sram_idle(u32 wfi_flags)
>  	return pm_ops->cpu_suspend(am33xx_do_wfi_sram, wfi_flags);
>  }
>  
> -static int __init am43xx_map_gic(void)
> +static int am43xx_map_gic(void)
>  {
>  	gic_dist_base = ioremap(AM43XX_GIC_DIST_BASE, SZ_4K);

Reviewed-by: Nishanth Menon <nm@...com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource