linux-kernel - Re: [PATCH net-next v1 1/1] net: usb: smsc95xx: add support for ethtool pause parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d451fa3b-e97d-4b01-a0bc-1a296777f004@lunn.ch>
Date: Fri, 18 Jul 2025 15:03:21 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Steve Glendinning <steve.glendinning@...well.net>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next v1 1/1] net: usb: smsc95xx: add support for
 ethtool pause parameters

On Fri, Jul 18, 2025 at 09:51:56AM +0200, Oleksij Rempel wrote:
> Implement ethtool .get_pauseparam and .set_pauseparam handlers for
> configuring flow control on smsc95xx. The driver now supports enabling
> or disabling transmit and receive pause frames, with or without
> autonegotiation. Pause settings are applied during link-up based on
> current PHY state and user configuration.
> 
> Previously, the driver used phy_get_pause() during link-up handling,
> but lacked initialization and an ethtool interface to configure pause
> modes. As a result, flow control support was effectively non-functional.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew