linux-kernel - Re: [PATCH v9 4/6] input: pf1550: add onkey support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67ki6m7dg5sbh7wknrnlermv5l3pw5fyx4agjtljbv54e5pxyj@d3l5jbz7osiz>
Date: Fri, 18 Jul 2025 13:16:16 +0000
From: Sean Nyekjaer <sean@...nix.com>
To: samuel.kayode@...oirfairelinux.com
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Sebastian Reichel <sre@...nel.org>, Frank Li <Frank.li@....com>, imx@...ts.linux.dev, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, linux-pm@...r.kernel.org, Abel Vesa <abelvesa@...nel.org>, Abel Vesa <abelvesa@...ux.com>, Robin Gong <b38343@...escale.com>, Robin Gong <yibin.gong@....com>, Enric Balletbo i Serra <eballetbo@...il.com>, Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH v9 4/6] input: pf1550: add onkey support

On Wed, Jul 16, 2025 at 11:11:47AM +0100, Samuel Kayode via B4 Relay wrote:
> From: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
> 
> Add support for the onkey of the pf1550 PMIC.
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Reviewed-by: Frank Li <Frank.Li@....com>
> Signed-off-by: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
> ---

[...]

> +
> +static int pf1550_onkey_probe(struct platform_device *pdev)
> +{
> +	struct onkey_drv_data *onkey;
> +	struct input_dev *input;
> +	bool key_power = false;
> +	int i, irq, error;
> +
> +	onkey = devm_kzalloc(&pdev->dev, sizeof(*onkey), GFP_KERNEL);
> +	if (!onkey)
> +		return -ENOMEM;
> +
> +	onkey->dev = &pdev->dev;
> +
> +	onkey->pf1550 = dev_get_drvdata(pdev->dev.parent);
> +	if (!onkey->pf1550->regmap)
> +		return dev_err_probe(&pdev->dev, -ENODEV,
> +				     "failed to get regmap\n");
> +
> +	onkey->wakeup = device_property_read_bool(pdev->dev.parent,
> +						  "wakeup-source");
> +
> +	if (device_property_read_bool(pdev->dev.parent,
> +				      "nxp,disable-key-power")) {
> +		error = regmap_write(onkey->pf1550->regmap,
> +				     PF1550_PMIC_REG_PWRCTRL1, 0);

I would use regmap_clear_bits() here.

/Sean