linux-kernel - Re: [PATCH] cdx: Fix missing GENERIC_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b39e24b-6221-4de9-b45b-464c666da8ad@linaro.org>
Date: Fri, 18 Jul 2025 15:34:25 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alex Williamson <alex.williamson@...hat.com>
Cc: Nipun Gupta <nipun.gupta@....com>, Nikhil Agarwal
 <nikhil.agarwal@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] cdx: Fix missing GENERIC_MSI_IRQ on compile test

On 17/07/2025 21:33, Alex Williamson wrote:
> On Wed, 16 Jul 2025 08:49:04 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
>> CDX_BUS driver uses msi_setup_device_data() which is selected by
>> GENERIC_MSI_IRQ, thus compile testing without the latter failed:
>>
>>   /usr/bin/ld: drivers/cdx/cdx.o: in function `cdx_probe':
>>   build/drivers/cdx/cdx.c:314: undefined reference to `msi_setup_device_data'
>>
>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
>> Closes: https://lore.kernel.org/all/b2c54a12-480c-448a-8b90-333cb03d9c14@infradead.org/
>> Fixes: 7f81907b7e3f ("cdx: Enable compile testing")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  drivers/cdx/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/cdx/Kconfig b/drivers/cdx/Kconfig
>> index 1f1e360507d7..3af41f51cf38 100644
>> --- a/drivers/cdx/Kconfig
>> +++ b/drivers/cdx/Kconfig
>> @@ -8,6 +8,7 @@
>>  config CDX_BUS
>>  	bool "CDX Bus driver"
>>  	depends on OF && ARM64 || COMPILE_TEST
>> +	select GENERIC_MSI_IRQ
>>  	help
>>  	  Driver to enable Composable DMA Transfer(CDX) Bus. CDX bus
>>  	  exposes Fabric devices which uses composable DMA IP to the
> 
> This looks incomplete to me.  The Makefile has:

Just FYI (because there was no public email), Greg applied this one, so
whatever we decide here will be on top.

> 
> ifdef CONFIG_GENERIC_MSI_IRQ
> obj-$(CONFIG_CDX_BUS) += cdx_msi.o
> endif
> 

Yes, this should be dropped in such case, at least with my patch.


Best regards,
Krzysztof