linux-kernel - Re: [PATCH net 2/2] net/mlx5: E-Switch, Fix peer miss rules to use peer eswitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250718135909.GB2459@horms.kernel.org>
Date: Fri, 18 Jul 2025 14:59:09 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Saeed Mahameed <saeed@...nel.org>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leon@...nel.org>,
	Saeed Mahameed <saeedm@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, Shahar Shitrit <shshitrit@...dia.com>
Subject: Re: [PATCH net 2/2] net/mlx5: E-Switch, Fix peer miss rules to use
 peer eswitch

On Thu, Jul 17, 2025 at 03:06:10PM +0300, Tariq Toukan wrote:
> From: Shahar Shitrit <shshitrit@...dia.com>
> 
> In the original design, it is assumed local and peer eswitches have the
> same number of vfs. However, in new firmware, local and peer eswitches
> can have different number of vfs configured by mlxconfig.  In such
> configuration, it is incorrect to derive the number of vfs from the
> local device's eswitch.
> 
> Fix this by updating the peer miss rules add and delete functions to use
> the peer device's eswitch and vf count instead of the local device's
> information, ensuring correct behavior regardless of vf configuration
> differences.
> 
> Fixes: ac004b832128 ("net/mlx5e: E-Switch, Add peer miss rules")
> Signed-off-by: Shahar Shitrit <shshitrit@...dia.com>
> Reviewed-by: Mark Bloch <mbloch@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>