linux-kernel - Re: [PATCH v3] char: xillybus: Replace deprecated MSI API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d3513e3-6294-b6df-189a-cc3bee76f0a3@outbound.gmail.com>
Date: Fri, 18 Jul 2025 16:19:49 +0200
From: Eli Billauer <eli.billauer@...il.com>
To: Salah Triki <salah.triki@...il.com>, Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] char: xillybus: Replace deprecated MSI API

Hello,

On 18/07/2025 2:55, Salah Triki wrote:

> +static void xilly_pci_free_irq_vectors(void *data)
> +{
> +	pci_free_irq_vectors(data);
> +}
> +

I'm sorry, but I have mislead you: The call to pci_free_irq_vectors() is 
done automatically by the kernel's own pcim_msi_release() function if 
the device is managed, which it is. So the driver is functionally 
correct in this matter as is. The only remaining issue is the deprecated 
API.

I discovered this using ftrace on the relevant functions in the kernel, 
as I was preparing for testing your patch against hardware.

Regards,
   Eli