linux-kernel - Re: [PATCH 1/2] staging: sm750fb: make const arrays static const char * const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa4a160b-1f0d-4983-8532-bd22214d7114@suswa.mountain>
Date: Fri, 18 Jul 2025 17:53:25 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ignacio Peña <ignacio.pena87@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: sm750fb: make const arrays static const
 char * const

On Thu, Jul 17, 2025 at 11:49:13PM -0400, Ignacio Peña wrote:
> Fix checkpatch warning:
> "WARNING: static const char * array should probably be
>  static const char * const"
> 
> This makes both the array and its contents immutable, which is the
> intended behavior for these constant string arrays:
> - g_fbmode: array of framebuffer mode strings
> - fixId: array of framebuffer device names
> 
> Signed-off-by: Ignacio Peña <ignacio.pena87@...il.com>

This is a v2 patch.  On the first version of this patch I told you
that it breaks the build.  So I guess now you're trying to fix it
by making fixId const as well?  It's unclear.

Anyway, it still breaks the build.

regards,
dan carpenter