linux-kernel - Re: [PATCH] media: b2c2: flexcop-eeprom: Fix assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507190855.RA0Awmj9-lkp@intel.com>
Date: Sat, 19 Jul 2025 08:45:17 +0800
From: kernel test robot <lkp@...el.com>
To: Darshan Rathod <darshanrathod475@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org
Subject: Re: [PATCH] media: b2c2: flexcop-eeprom: Fix assignment in if
 condition

Hi Darshan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linuxtv-media-pending/master]
[also build test WARNING on sailus-media-tree/master linus/master media-tree/master sailus-media-tree/streams v6.16-rc6 next-20250718]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Darshan-Rathod/media-b2c2-flexcop-eeprom-Fix-assignment-in-if-condition/20250718-205456
base:   https://git.linuxtv.org/media-ci/media-pending.git master
patch link:    https://lore.kernel.org/r/20250718125245.82910-1-darshanrathod475%40gmail.com
patch subject: [PATCH] media: b2c2: flexcop-eeprom: Fix assignment in if condition
config: i386-randconfig-002-20250719 (https://download.01.org/0day-ci/archive/20250719/202507190855.RA0Awmj9-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250719/202507190855.RA0Awmj9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507190855.RA0Awmj9-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/common/b2c2/flexcop-eeprom.c: In function 'flexcop_eeprom_check_mac_addr':
>> drivers/media/common/b2c2/flexcop-eeprom.c:143:29: warning: operation on 'ret' may be undefined [-Wsequence-point]
     143 |                         ret = ret = -EINVAL;
   drivers/media/common/b2c2/flexcop-eeprom.c:149:1: error: expected declaration or statement at end of input
     149 | EXPORT_SYMBOL(flexcop_eeprom_check_mac_addr);
         | ^~~~~~~~~~~~~
>> drivers/media/common/b2c2/flexcop-eeprom.c:150: warning: control reaches end of non-void function [-Wreturn-type]


vim +/ret +143 drivers/media/common/b2c2/flexcop-eeprom.c

   130	
   131	/* JJ's comment about extended == 1: it is not presently used anywhere but was
   132	 * added to the low-level functions for possible support of EUI64 */
   133	int flexcop_eeprom_check_mac_addr(struct flexcop_device *fc, int extended)
   134	{
   135		u8 buf[8];
   136		int ret = 0;
   137	
   138		ret = flexcop_eeprom_lrc_read(fc, 0x3f8, buf, 8, 4);
   139	
   140		if (ret == 0) {
   141			if (extended != 0) {
   142				err("TODO: extended (EUI64) MAC addresses aren't completely supported yet");
 > 143				ret = ret = -EINVAL;
   144			} else {
   145				memcpy(fc->dvb_adapter.proposed_mac, buf, 6);
   146			}
   147			return ret;
   148	}
   149	EXPORT_SYMBOL(flexcop_eeprom_check_mac_addr);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki