linux-kernel - Re: [PATCH] xfs: scrub: remove unnecessary braces and fix …

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f12a445e-536b-44e4-9291-a10dd16f227f@web.de>
Date: Sat, 19 Jul 2025 10:33:19 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Muhammad Ahmed <muhammad.ahmed.27@...mail.com>, linux-xfs@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Carlos Maiolino <cem@...nel.org>,
 "Darrick J. Wong" <djwong@...nel.org>
Subject: Re: [PATCH] xfs: scrub: remove unnecessary braces and fix …

> This patch removes unnecessary braces around simple if-else blocks and

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n94

How do you think about to use the following code variant?

		xrep_findparent_scan_found(pscan, p->delta > 0 ? p->dp->i_ino : NULLFSINO);

> fixes inconsistent indentation in fs/xfs/scrub/findparent.c to comply
> with kernel coding style guidelines.

Please split possible changes into separate update steps.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n81

Regards,
Markus