linux-kernel - Re: [PATCH v7 06/10] gpio: Add new gpio-macsmc driver for Apple Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f9fdb3e-9655-44ce-8a2f-c1628c88c929@kernel.org>
Date: Sat, 19 Jul 2025 14:59:41 +0200
From: Sven Peter <sven@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Lee Jones <lee@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 Hector Martin <marcan@...can.st>, Neal Gompa <neal@...pa.dev>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, Sebastian Reichel <sre@...nel.org>,
 linux-kernel@...r.kernel.org, Marc Zyngier <maz@...nel.org>,
 linux-pm@...r.kernel.org, "Russell King (Oracle)"
 <rmk+kernel@...linux.org.uk>, Conor Dooley <conor+dt@...nel.org>,
 Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v7 06/10] gpio: Add new gpio-macsmc driver for Apple Macs

Hi Linus, Bartosz,

top posting on purpose: are you fine if Lee takes this commit with the 
rest through his mfd tree?


Thanks,


Sven



On 10.06.25 17:29, Sven Peter wrote:
> From: Hector Martin <marcan@...can.st>
> 
> This driver implements the GPIO service on top of the SMC framework
> on Apple Mac machines. In particular, these are the GPIOs present in the
> PMU IC which are used to control power to certain on-board devices.
> 
> Although the underlying hardware supports various pin config settings
> (input/output, open drain, etc.), this driver does not implement that
> functionality and leaves it up to the firmware to configure things
> properly. We also don't yet support interrupts/events. This is
> sufficient for device power control, which is the only thing we need to
> support at this point. More features will be implemented when needed.
> 
> To our knowledge, only Apple Silicon Macs implement this SMC feature.
> 
> Signed-off-by: Hector Martin <marcan@...can.st>
> Reviewed-by: Bartosz Golaszewski <brgl@...ev.pl>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Reviewed-by: Sven Peter <sven@...nel.org>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
> Reviewed-by: Neal Gompa <neal@...pa.dev>
> Signed-off-by: Sven Peter <sven@...nel.org>
> ---
>   MAINTAINERS                |   1 +
>   drivers/gpio/Kconfig       |  10 ++
>   drivers/gpio/Makefile      |   1 +
>   drivers/gpio/gpio-macsmc.c | 292 +++++++++++++++++++++++++++++++++++++++++++++
>   4 files changed, 304 insertions(+)

[...]