linux-kernel - Re: [PATCH] media: b2c2: flexcop-eeprom: Fix assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fbe09fd7-c73e-4bb5-ace0-ec5eefad0765@web.de>
Date: Sat, 19 Jul 2025 15:50:20 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Darshan Rathod <darshanrathod475@...il.com>, linux-media@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] media: b2c2: flexcop-eeprom: Fix assignment in if
 condition

> Function flexcop_eeprom_check_mac_addr() contains an
> assignment in an 'if' condition. This coding style is not
> accepted in the Linux kernel as it can conceal bugs.
…

You may occasionally put more than 60 characters into text lines
of such a change description.


> Also, correct a few off-by-one spaces in a function call and
> variable declaration.

Please split possible changes into separate update steps.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n81

Regards,
Markus