linux-kernel - Re: [PATCH 3/7] fs/proc: replace "__auto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63adc48b-9b81-4f35-9462-0de103474d13@p183>
Date: Sat, 19 Jul 2025 17:26:28 +0300
From: Alexey Dobriyan <adobriyan@...il.com>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: Eugenio Pérez <eperezma@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Alexei Starovoitov <ast@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrii Nakryiko <andrii@...nel.org>,
	Arnd Bergmann <arnd@...nel.org>, Borislav Petkov <bp@...en8.de>,
	Cong Wang <cong.wang@...edance.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Daniel Borkmann <daniel@...earbox.net>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	David Laight <David.Laight@...lab.com>,
	David Lechner <dlechner@...libre.com>,
	Dinh Nguyen <dinguyen@...nel.org>,
	Eduard Zingerman <eddyz87@...il.com>,
	Gatlin Newhouse <gatlin.newhouse@...il.com>,
	Hao Luo <haoluo@...gle.com>, Ingo Molnar <mingo@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jakub Sitnicki <jakub@...udflare.com>,
	Jan Hendrik Farr <kernel@...rr.cc>,
	Jason Wang <jasowang@...hat.com>, Jiri Olsa <jolsa@...nel.org>,
	John Fastabend <john.fastabend@...il.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Josh Poimboeuf <jpoimboe@...nel.org>, KP Singh <kpsingh@...nel.org>,
	Kees Cook <kees@...nel.org>,
	Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
	Marc Herbert <Marc.Herbert@...ux.intel.com>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Mateusz Guzik <mjguzik@...il.com>, Michal Luczaj <mhal@...x.co>,
	Miguel Ojeda <ojeda@...nel.org>, Mykola Lysenko <mykolal@...com>,
	NeilBrown <neil@...wn.name>, Peter Zijlstra <peterz@...radead.org>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Sami Tolvanen <samitolvanen@...gle.com>,
	Shuah Khan <shuah@...nel.org>, Song Liu <song@...nel.org>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Thomas Gleixner <tglx@...utronix.de>,
	Thorsten Blum <thorsten.blum@...ux.dev>,
	Uros Bizjak <ubizjak@...il.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Yafang Shao <laoar.shao@...il.com>, Ye Bin <yebin10@...wei.com>,
	Yonghong Song <yonghong.song@...ux.dev>,
	Yufeng Wang <wangyufeng@...inos.cn>, bpf@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-sparse@...r.kernel.org,
	virtualization@...ts.linux.dev, x86@...nel.org
Subject: Re: [PATCH 3/7] fs/proc: replace "__auto_type" with "auto"

On Fri, Jul 18, 2025 at 02:32:46PM -0700, H. Peter Anvin wrote:
> Replace uses of "__auto_type" in fs/proc/inode.c with "auto".

>  static ssize_t pde_read(struct proc_dir_entry *pde, struct file *file, char __user *buf, size_t count, loff_t *ppos)
>  {
> -	__auto_type read = pde->proc_ops->proc_read;
> +	auto read = pde->proc_ops->proc_read;

Thanks! I'd prefer "const auto" but OK.

Reviewed-by: Alexey Dobriyan <adobriyan@...il.com>