linux-kernel - Re: [PATCH v15 3/3] rust: platform: add resource accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=LAaQuii3O_+Pa+wYSXyd_Joi8aecNGVqn5fww8PbZ7Q@mail.gmail.com>
Date: Sat, 19 Jul 2025 18:19:53 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Daniel Almeida <daniel.almeida@...labora.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v15 3/3] rust: platform: add resource accessors

On Sat, Jul 19, 2025 at 3:15 PM Danilo Krummrich <dakr@...nel.org> wrote:
>
> @Miguel: What's the preferred way dealing with this? I assume we just want to
> ignore this warning for the affected compiler versions?

Yeah, we had this in the past -- when I introduced the lint, I just
went with putting in the middle, e.g. in `rust/kernel/sync/lock.rs`'s
`do_unlocked`.

It has been fairly confusing, because long ago AFAIU it was not
intended to be supported, but then they introduced a config option for
it, and then it was made the default, but there were false positives.

It seems it has been finally fixed in
https://github.com/rust-lang/rust-clippy/pull/13888 for Rust 1.87.0.

I would say just put it in the middle. The only advantage of using an
`allow` would be using the "reason" field to say we can move it >=
1.87, but if we really want to move it, we can always use a normal
comment to say so instead.

Cheers,
Miguel