linux-kernel - Re: [PATCH] rust: list: undo unintended replacement of method name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-ks9=Ye4v4g0roTu_CJSveRwj6c6P95kGfzy29VEh2c8XHKA@mail.gmail.com>
Date: Sat, 19 Jul 2025 17:05:37 -0400
From: Tamir Duberstein <tamird@...il.com>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH] rust: list: undo unintended replacement of method name

On Sat, Jul 19, 2025 at 2:37 PM Miguel Ojeda <ojeda@...nel.org> wrote:
>
> When we renamed `Opaque::raw_get` to `cast_into`, there was one
> replacement that was not supposed to be there.
>
> It does not cause an issue so far because it is inside a macro rule (the
> `ListLinksSelfPtr` one) that is unused so far. However, it will start
> to be used soon.
>
> Thus fix it now.
>
> Fixes: 64fb810bce03 ("rust: types: rename Opaque::raw_get to cast_into")
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Reviewed-by: Tamir Duberstein <tamird@...il.com>

> ---
>  rust/kernel/list/impl_list_item_mod.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/list/impl_list_item_mod.rs b/rust/kernel/list/impl_list_item_mod.rs
> index c1edba0a9501..3f6c30e14904 100644
> --- a/rust/kernel/list/impl_list_item_mod.rs
> +++ b/rust/kernel/list/impl_list_item_mod.rs
> @@ -252,7 +252,7 @@ unsafe fn view_value(links_field: *mut $crate::list::ListLinks<$num>) -> *const
>                  // the pointer stays in bounds of the allocation.
>                  let self_ptr = unsafe { (links_field as *const u8).add(spoff) }
>                      as *const ::core::cell::UnsafeCell<*const Self>;
> -                let cell_inner = ::core::cell::UnsafeCell::cast_into(self_ptr);
> +                let cell_inner = ::core::cell::UnsafeCell::raw_get(self_ptr);
>                  // SAFETY: This is not a data race, because the only function that writes to this
>                  // value is `prepare_to_insert`, but by the safety requirements the
>                  // `prepare_to_insert` method may not be called in parallel with `view_value` or
>
> base-commit: 23b128bba76776541dc09efaf3acf6242917e1f0
> --
> 2.50.1
>