linux-kernel - Re: [PATCH v4 6/6] rust: list: remove OFFSET constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kvYuoSSOruDQiEo5ppSDvtxSzQ4R6rxdN9RBkucBRuew@mail.gmail.com>
Date: Sat, 19 Jul 2025 23:09:27 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pci@...r.kernel.org
Subject: Re: [PATCH v4 6/6] rust: list: remove OFFSET constants

On Wed, Jul 9, 2025 at 9:31 PM Tamir Duberstein <tamird@...il.com> wrote:
>
> -/// Declares that this type has a `ListLinks<ID>` field at a fixed offset.
> +/// Declares that this type has a [`ListLinks<ID>`] field.

I was applying this series the other day, and I noticed these
doc-related changes in the patch, which are appreciated (I think you
did it to make it consistent with the other lines you were adding with
intra-doc links), but I think in general it is better to clean those
separately in a patch first.

I am mentioning it because the docs do not build due to those --
please check the `rustdoc` target for patches, especially if it is a
non-trivial change.

I also did another change to make the examples (in the other patch)
build with the minimum Rust version. It is good to test that too,
since sometimes that can slip, especially as the window of versions
grow.

Anyway, the examples/series here caught another issue with a previous
patch, so that is good news :)

Thanks!

Cheers,
Miguel