linux-kernel - Re: [PATCH] hwmon: (gsc-hwmon) fix fan pwm setpoint show functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10e92428-b233-4c7a-b762-36980ce104e0@roeck-us.net>
Date: Sat, 19 Jul 2025 14:58:31 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Tim Harvey <tharvey@...eworks.com>
Cc: Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] hwmon: (gsc-hwmon) fix fan pwm setpoint show functions

On Fri, Jul 18, 2025 at 01:02:59PM -0700, Tim Harvey wrote:
> The Linux hwmon sysfs API values for pwmX_auto_pointY_pwm represent an
> integer value between 0 (0%) to 255 (100%) and the pwmX_auto_pointY_temp
> represent millidegrees Celcius.
> 
> Commit a6d80df47ee2 ("hwmon: (gsc-hwmon) fix fan pwm temperature
> scaling") properly addressed the incorrect scaling in the
> pwm_auto_point_temp_store implementation but erroneously scaled
> the pwm_auto_point_pwm_show (pwm value) instead of the
> pwm_auto_point_temp_show (temp value) resulting in:
>  # cat /sys/class/hwmon/hwmon0/pwm1_auto_point6_pwm
>  25500
>  # cat /sys/class/hwmon/hwmon0/pwm1_auto_point6_temp
>  4500
> 
> Fix the scaling of these attributes:
>  # cat /sys/class/hwmon/hwmon0/pwm1_auto_point6_pwm
>  255
>  # cat /sys/class/hwmon/hwmon0/pwm1_auto_point6_temp
>  45000
> 
> Fixes: a6d80df47ee2 ("hwmon: (gsc-hwmon) fix fan pwm temperature scaling")
> Cc: stable@...r.kernel.org
> Signed-off-by: Tim Harvey <tharvey@...eworks.com>

Applied.

Thanks,
Guenter