linux-kernel - Re: [PATCH v2 3/3] hwmon: ina238: Add support for INA228

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1fc421b7-80fc-458b-8ac0-afa61ed03568@roeck-us.net>
Date: Sat, 19 Jul 2025 15:01:04 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Jonas Rebmann <jre@...gutronix.de>
Cc: Jean Delvare <jdelvare@...e.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>,
	devicetree@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v2 3/3] hwmon: ina238: Add support for INA228

On Fri, Jul 18, 2025 at 04:12:50PM +0200, Jonas Rebmann wrote:
> Add support for the Texas Instruments INA228 Ultra-Precise
> Power/Energy/Charge Monitor.
> 
> The INA228 is very similar to the INA238 but offers four bits of extra
> precision in the temperature, voltage and current measurement fields.
> It also supports energy and charge monitoring, the latter of which is
> not supported through this patch.
> 
> While it seems in the datasheet that some constants such as LSB values
> differ between the 228 and the 238, they differ only for those registers
> where four bits of precision have been added and they differ by a factor
> of 16 (VBUS, VSHUNT, DIETEMP, CURRENT).
> 
> Therefore, the INA238 constants are still applicable with regard
> to the bit of the same significance.
> 
> Signed-off-by: Jonas Rebmann <jre@...gutronix.de>

Applied.

Thanks,
Guenter