linux-kernel - Re: [PATCH v6] bus: mhi: host: don't free bhie tables during suspend/hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yywgwnk3aky2qqyxnyiisqxdi5a545tijtigm3al3yyzxrjnst@ged5v7i24nsc>
Date: Sat, 19 Jul 2025 08:54:35 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Jeff Johnson <jjohnson@...nel.org>, 
	Jeff Hugo <jeff.hugo@....qualcomm.com>, Youssef Samir <quic_yabdulra@...cinc.com>, 
	Matthew Leung <quic_mattleun@...cinc.com>, Carl Vanderlip <quic_carlv@...cinc.com>, 
	Yan Zhen <yanzhen@...o.com>, Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>, 
	Alex Elder <elder@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Kunwu Chan <chentao@...inos.cn>, "Dr. David Alan Gilbert" <linux@...blig.org>, 
	Troy Hanson <quic_thanson@...cinc.com>, Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: kernel@...labora.com, sebastian.reichel@...labora.com, 
	Jeff Johnson <jeff.johnson@....qualcomm.com>, Baochen Qiang <quic_bqiang@...cinc.com>, 
	Sumit Garg <sumit.garg@...nel.org>, mhi@...ts.linux.dev, linux-arm-msm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, ath11k@...ts.infradead.org, 
	ath12k@...ts.infradead.org
Subject: Re: [PATCH v6] bus: mhi: host: don't free bhie tables during
 suspend/hibernation

On Tue, Jun 17, 2025 at 12:58:51PM GMT, Manivannan Sadhasivam wrote:
> 
> On Fri, 16 May 2025 23:49:31 +0500, Muhammad Usama Anjum wrote:
> > Fix dma_direct_alloc() failure at resume time during bhie_table
> > allocation because of memory pressure. There is a report where at
> > resume time, the memory from the dma doesn't get allocated and MHI
> > fails to re-initialize.
> > 
> > To fix it, don't free the memory at power down during suspend /
> > hibernation. Instead, use the same allocated memory again after every
> > resume / hibernation. This patch has been tested with resume and
> > hibernation both.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] bus: mhi: host: don't free bhie tables during suspend/hibernation
>       commit: df75d6d7ce922645e674f5d591c7333f11027cdc
> 

Dropped this patch from mhi-next as Greg is opposed to drivers keeping memory
during suspend [1].

Please resubmit once the consensus is reached.

- Mani

[1] https://lore.kernel.org/mhi/2025071722-panther-legwarmer-d2be@gregkh/

-- 
மணிவண்ணன் சதாசிவம்