linux-kernel - Re: [PATCH v4 0/3] rust: Add pr_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHsSAaLDjp8TTXAw@Mac.home>
Date: Fri, 18 Jul 2025 20:33:21 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Onur Özkan <work@...rozkan.dev>
Cc: Andreas Hindborg <a.hindborg@...nel.org>, jens.korinth@...a.io,
	Jens Korinth via B4 Relay <devnull+jens.korinth.tuta.io@...nel.org>,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
	Trevor Gross <tmgross@...ch.edu>,
	Rust For Linux <rust-for-linux@...r.kernel.org>,
	FUJITA Tomonori <fujita.tomonori@...il.com>,
	Dirk Behme <dirk.behme@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 0/3] rust: Add pr_*_once macros134

On Thu, Jul 17, 2025 at 07:07:13PM +0300, Onur Özkan wrote:
> On Tue, 11 Feb 2025 16:42:25 +0100
> Andreas Hindborg <a.hindborg@...nel.org> wrote:
> 
> > <jens.korinth@...a.io> writes:
> > 
> > > Hi!
> > >
> > >> Thanks for the patch! Do you plan on sending a new version? If
> > >>not, do you mind if I send v5?
> > >
> > > I think there is currently no consensus on how exactly it should be
> > > done (or at least I was confused about that). If you´re actively
> > > using the patch please go ahead! Active usage is always the best
> > > argument in such cases.
> > 
> > I was informed this patch set is the correct way to emit a warning in
> > the module_params patch set [1].
> > 
> > I did not follow all the discussion so I am not sure either. But I'll
> > look into the discussion then.
> > 
> > 
> > Best regards,
> > Andreas Hindborg
> > 
> > 
> > 
> > [1]
> > https://lore.kernel.org/rust-for-linux/20250204-module-params-v3-v5-0-bf5ec2041625@kernel.org/
> > 
> > 
> 
> I have reviewed the patch series from start to finish. I am not
> using or depending the patch actively but I can send v5 sometime
> soon (I will have some space next week) if you would like.
> 

Note that you need to use LKMM atomics [1], and you should really use
a 32bit atomic at the beginning. Thanks!

There are a few explanations on why we want to avoid use Rust native
atomics:

	https://lwn.net/Articles/993785/
	https://lore.kernel.org/rust-for-linux/CAHk-=whkQk=zq5XiMcaU3xj4v69+jyoP-y6Sywhq-TvxSSvfEA@mail.gmail.com/

[1]: https://lore.kernel.org/rust-for-linux/20250719030827.61357-1-boqun.feng@gmail.com/

Regards,
Boqun

> Regards,
> Onur