linux-kernel - Re: [PATCH rdma-next 1/1] RDMA/mana_ib: add support of multiple ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250720082427.GF402218@unreal>
Date: Sun, 20 Jul 2025 11:24:27 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Konstantin Taranov <kotaranov@...ux.microsoft.com>
Cc: kotaranov@...rosoft.com, longli@...rosoft.com, jgg@...pe.ca,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: add support of multiple ports

On Fri, Jul 18, 2025 at 03:20:48AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@...rosoft.com>
> 
> If the HW indicates support of multiple ports for rdma, create an IB device
> with a port per netdev in the ethernet mana driver.
> 
> CM is only available on port 1, but RC QPs are supported on all
> ports.
> 
> Signed-off-by: Konstantin Taranov <kotaranov@...rosoft.com>
> ---
>  drivers/infiniband/hw/mana/device.c  | 107 +++++++++++++--------------
>  drivers/infiniband/hw/mana/main.c    |  13 +++-
>  drivers/infiniband/hw/mana/mana_ib.h |   1 +
>  3 files changed, 64 insertions(+), 57 deletions(-)

mana_get_primary_netdev() can return NULL.

You should check return value even it can't be happen or remove "if
(port_index >= ac->num_ports)" that returns NULL.

Thanks