linux-kernel - Re: [PATCH] iio: adc: ad4170-4: Correctly update filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43ed8918-0116-4e8b-943c-2e62906b1fdb@web.de>
Date: Sun, 20 Jul 2025 10:48:41 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Marcelo Schmitt <marcelo.schmitt@...log.com>, linux-iio@...r.kernel.org
Cc: Marcelo Schmitt <marcelo.schmitt1@...il.com>,
 LKML <linux-kernel@...r.kernel.org>, Andy Shevchenko <andy@...nel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 David Lechner <dlechner@...libre.com>, Jonathan Cameron <jic23@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Nuno Sá
 <nuno.sa@...log.com>, Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH] iio: adc: ad4170-4: Correctly update filter_fs after
 filter type change

…
> +++ b/drivers/iio/adc/ad4170-4.c
> @@ -880,10 +880,12 @@ static int ad4170_set_filter_type(struct iio_dev *indio_dev,
>  			return -EBUSY;
>  
>  		if (val == AD4170_SINC5_AVG || val == AD4170_SINC3)
> -			setup->filter_fs = clamp(val, AD4170_SINC3_MIN_FS,
> +			setup->filter_fs = clamp(setup->filter_fs,
> +						 AD4170_SINC3_MIN_FS,
>  						 AD4170_SINC3_MAX_FS);
>  		else
> -			setup->filter_fs = clamp(val, AD4170_SINC5_MIN_FS,
> +			setup->filter_fs = clamp(setup->filter_fs,
> +						 AD4170_SINC5_MIN_FS,
>  						 AD4170_SINC5_MAX_FS);
>  
>  		setup->filter &= ~AD4170_FILTER_FILTER_TYPE_MSK;

How do you think about to use the following code variant?

		setup->filter_fs = (val == AD4170_SINC5_AVG || val == AD4170_SINC3)
				   ? clamp(setup->filter_fs,
					   AD4170_SINC3_MIN_FS, AD4170_SINC3_MAX_FS)
				   : clamp(setup->filter_fs,
					   AD4170_SINC5_MIN_FS, AD4170_SINC5_MAX_FS);


Regards,
Markus