linux-kernel - Re: [PATCH net 1/2] net/mlx5: Fix memory leak in cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73bede3e-c00e-4a55-9095-b9a3dc8765a6@web.de>
Date: Sun, 20 Jul 2025 14:15:05 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Chiara Meiohas <cmeiohas@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
 Vlad Dumitrescu <vdumitrescu@...dia.com>, linux-rdma@...r.kernel.org,
 netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Leon Romanovsky <leon@...nel.org>,
 Moshe Shemesh <moshe@...dia.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Gal Pressman <gal@...dia.com>,
 Mark Bloch <mbloch@...dia.com>, Saeed Mahameed <saeed@...nel.org>,
 Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net 1/2] net/mlx5: Fix memory leak in cmd_exec()

…
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> @@ -1947,8 +1947,8 @@ static int cmd_exec(struct mlx5_core_dev *dev, void *in, int in_size, void *out,
>  
>  	err = mlx5_cmd_invoke(dev, inb, outb, out, out_size, callback, context,
>  			      pages_queue, token, force_polling);
> -	if (callback)
> -		return err;
> +	if (callback && !err)

Can an other order become more appropriate for the items of this condition check?

> +		return 0;
>  
>  	if (err > 0) /* Failed in FW, command didn't execute */
>  		err = deliv_status_to_err(err);

Regards,
Markus