linux-kernel - Re: [PATCH net-next v4 0/4] net: add local address bind support to vxlan and geneve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHz2Y6Be3G4_P7ZM@shredder>
Date: Sun, 20 Jul 2025 17:00:03 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Richard Gobert <richardbgobert@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, dsahern@...nel.org,
	razor@...ckwall.org, petrm@...dia.com, menglong8.dong@...il.com,
	daniel@...earbox.net, martin.lau@...nel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 0/4] net: add local address bind support to
 vxlan and geneve

On Thu, Jul 17, 2025 at 01:54:08PM +0200, Richard Gobert wrote:
> This series adds local address bind support to both vxlan
> and geneve sockets.

A few comments:

1. Binding the VXLAN socket to the local address does break
functionality. Run the VXLAN selftests in tools/testing/selftests/net/
and you will see failures. IOW, you cannot change the default behavior.
You might not need the first patch if the new behavior is opt-in rather
than opt-out.

2. Please add a selftest for the new functionality. See the existing
VXLAN selftests for reference. There is no need to wait for the iproute2
patch to be accepted. You can have a check to skip the test if iproute2
does not have the required functionality.

3. The cover letter should explain the motivation for these patches.
Currently it only explains what the patches do.